Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insomnia: Fix .desktop to link to Nix bin #59870

Merged
merged 1 commit into from Apr 24, 2019
Merged

insomnia: Fix .desktop to link to Nix bin #59870

merged 1 commit into from Apr 24, 2019

Conversation

phildenhoff
Copy link
Contributor

Motivation for this change

By default, the Insomnia package adds a .desktop icon with an Exec path of "/opt/insomnia/insomnia", but that's (generally!) not where Nix installs Insomnia.

Things done

I added a sed into the "installPhase" to replace the "/opt" path with the "$out" path.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that I can launch insomnia with the desktop file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants