Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

goxel: re-enable aarch64 #59882

Merged
merged 2 commits into from Apr 25, 2019
Merged

goxel: re-enable aarch64 #59882

merged 2 commits into from Apr 25, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Apr 19, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member Author

Mic92 commented Apr 19, 2019

@GrahamcOfBorg build goxel

Apparently fixed aarch64 support: guillaumechereau/goxel#125 (comment)

@Mic92
Copy link
Member Author

Mic92 commented Apr 19, 2019

@GrahamcOfBorg build goxel

@Mic92
Copy link
Member Author

Mic92 commented Apr 19, 2019

No idea, why this is still marked as unsupported.

c0bw3b
c0bw3b approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works indeed!

@c0bw3b c0bw3b merged commit 9bdcd2a into NixOS:master Apr 25, 2019
@Mic92 Mic92 deleted the goxel branch April 27, 2019 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis adisbladis requested changes

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mic92 @adisbladis @c0bw3b @GrahamcOfBorg