nixos/matrix-synapse: correct trusted_third_party_id_servers default #59880
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
the servers are equivalent and synchronized, but Riot defaults to use vector.im which leads to a nondescribing 401 error message when registering third party identifiers.
This adjusts the NixOS default to the upstream default:
https://github.com/matrix-org/synapse/blob/v0.99.3/docs/sample_config.yaml#L701
I think we should backport this to 19.03 for out of the box compatibility between a NixOS synapse installation and Riot, and as both servers are run by the same operators and contain the same data, I would consider this backward-compatible.
Maintainers: @Ralith @roblabla @Ekleog @pacien
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)