Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shadowfox: 1.5.2 -> 1.7.20, move to buildGoModule #59972

Merged
merged 1 commit into from Apr 22, 2019
Merged

shadowfox: 1.5.2 -> 1.7.20, move to buildGoModule #59972

merged 1 commit into from Apr 22, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 21, 2019

Motivation for this change

update, remove deps.nix

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c00w
Copy link
Contributor

c00w commented Apr 21, 2019

Any idea why this fails on darwin?

@dtzWill
Copy link
Member Author

dtzWill commented Apr 22, 2019

Not sure, maybe transient? Let's see...

@GrahamcOfBorg build shadowfox

@kalbasit kalbasit merged commit 54084dd into NixOS:master Apr 22, 2019
c0bw3b pushed a commit to c0bw3b/nixpkgs that referenced this pull request Apr 22, 2019
@dtzWill @c0bw3b
shadowfox: 1.5.2 -> 1.7.20, move to buildGoModule (NixOS#59972)
beb64ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @c00w @kalbasit @GrahamcOfBorg