Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

superTuxKart: 0.9.3 -> 1.0 #59973

Merged
merged 1 commit into from Apr 22, 2019
Merged

superTuxKart: 0.9.3 -> 1.0 #59973

merged 1 commit into from Apr 22, 2019

Conversation

aanderse
Copy link
Member

Motivation for this change

http://blog.supertuxkart.net/2019/04/supertuxkart-10-release.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse aanderse mentioned this pull request Apr 21, 2019
10 tasks
@aanderse
Copy link
Member Author

@peterhoeg how does this look?

@aanderse
Copy link
Member Author

@GrahamcOfBorg build superTuxKart

@teto
Copy link
Member

teto commented Apr 22, 2019

If it's not merged by then, i'll give the binary a try this evening.

@etu
Copy link
Contributor

etu commented Apr 22, 2019

I just built it and tried it both online and offline for like half an hour, seems to work well 😄

@etu etu merged commit 1f9943b into NixOS:master Apr 22, 2019
@aanderse aanderse deleted the super-tux-kart branch April 22, 2019 10:45
@teto
Copy link
Member

teto commented Apr 24, 2019

@aanderse thanks for the update. Works perfectly fine on my machine too. Too bad there are so few servers in Asia :(

@peterhoeg
Copy link
Member

This is getting seriously off-topic but I'll race you on the weekend @teto - Singapore to Tokyo should be fine!

@teto
Copy link
Member

teto commented Apr 24, 2019

in order to keep the issue "on-track" what's your IRC nickname (or we could schedule a race via discourse) ? I am more than willing to kick your ass :p

@peterhoeg
Copy link
Member

@peter:hoeg.com on matrix, peterhoeg on IRC.

For the rest of you guys subscribing to this issue - my apologies for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants