Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixbox: init at unstable-2019-04-20 #59967

Closed
wants to merge 1 commit into from
Closed

nixbox: init at unstable-2019-04-20 #59967

wants to merge 1 commit into from

Conversation

LinArcX
Copy link
Contributor

@LinArcX LinArcX commented Apr 21, 2019 •
edited

Motivation for this change

I need a central app to manage all nixos operations in one place. So with nixbox i can manage Derivations, Generations(delete them, list them, ..), manage channels, fix nix store, ... in single application without worry to memorize their commands.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

tomberek
tomberek approved these changes Apr 27, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds, runs and functions on Ubuntu

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/12

@timokau
Copy link
Member

timokau commented Apr 27, 2019

Since you apparently maintain that package, would you mind making a release first?

@timokau
Copy link
Member

timokau commented Apr 27, 2019

Also writing something in the motivation section here would be nice, since it adds a new package.

@c0bw3b
Copy link
Contributor

c0bw3b commented Apr 27, 2019

@LinArcX > I left a small PR on your tool: LinArcX/nixbox#1

And +1 on making a proper tagged release of it before inclusion in nixpkgs.

@ryantm ryantm changed the title nixbox: init at unstable-2019-04-20" nixbox: init at unstable-2019-04-20 Jan 6, 2020
ryantm
ryantm requested changes Jan 6, 2020
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make a tagged release

@wamserma
Copy link
Member

@LinArcX Are you willing to update this PR?
I see you made the release quite a while ago, but never came back to this PR.

@LinArcX
Copy link
Contributor Author

LinArcX commented May 23, 2020 •
edited

@wamserma Hi. This pr is OK IMO. Since I added a releas for it.

I don't know why it's not merged yet.

@wamserma
Copy link
Member

@LinArcX Are you willing to actively maintain this? Then please update the PR to use the release tag, otherwise please close it.

@LinArcX
Copy link
Contributor Author

LinArcX commented May 23, 2020

I don't have nuxpkgs right now. I close it. If anyone interest open new pr.

@LinArcX LinArcX closed this May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm requested changes

@tomberek tomberek tomberek approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@LinArcX @nixos-discourse @timokau @c0bw3b @wamserma @ryantm @tomberek @GrahamcOfBorg