Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mate: 1.20 -> 1.22 #59966

Merged
merged 60 commits into from Apr 24, 2019
Merged

mate: 1.20 -> 1.22 #59966

merged 60 commits into from Apr 24, 2019

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Apr 21, 2019

Motivation for this change

Update the MATE Desktop Environment to version 1.22.

MATE 1.22 released

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

Currently kio-extras fails to build on master (https://hydra.nixos.org/job/nixpkgs/trunk/kdeApplications.kio-extras.x86_64-linux), and services.xserver.desktopEnvironment.mate.enable depends on it, so trying to test it with this option enabled fails. Would be a good idea to fix kio-extras.

@romildo
Copy link
Contributor Author

romildo commented Apr 23, 2019

Currently kio-extras fails to build on master (https://hydra.nixos.org/job/nixpkgs/trunk/kdeApplications.kio-extras.x86_64-linux), and services.xserver.desktopEnvironment.mate.enable depends on it, so trying to test it with this option enabled fails. Would be a good idea to fix kio-extras.

I am not seeing how MATE depends on kio-extras. What depends on it seems to be plasma5.

@infinisil
Copy link
Member

Oh, I'm stupid, I used the demo.nix profile, which apparently sets plasma5.enable = true. Sorry! I'll try again without this.

Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this in a VM with desktopEnvironments.mate.enable = true, works well :)

@romildo romildo merged commit 6a5f81e into NixOS:master Apr 24, 2019
@romildo romildo deleted the upd.mate branch April 24, 2019 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants