Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

guake: fix by setting strictDeps to false #59968

Merged
merged 1 commit into from Apr 22, 2019
Merged

guake: fix by setting strictDeps to false #59968

merged 1 commit into from Apr 22, 2019

Conversation

markuskowa
Copy link
Member

Motivation for this change

StrictDeps breaks guake (see #56943).

Closes #59930

Needs backport to 19.03

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    Tested on NixOS 19.03
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markuskowa markuskowa requested a review from jtojnar April 21, 2019 16:21
@worldofpeace worldofpeace merged commit eb60ddb into NixOS:master Apr 22, 2019
@worldofpeace
Copy link
Contributor

backported in 4c57db8

@markuskowa markuskowa deleted the fix-guake branch April 22, 2019 11:13
@jtojnar jtojnar mentioned this pull request Apr 24, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Guake won't start on NixOS 19.03
4 participants
@markuskowa @worldofpeace @jtojnar @GrahamcOfBorg