Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpPackages: update php packages #59904

Merged
merged 15 commits into from Apr 22, 2019
Merged

phpPackages: update php packages #59904

merged 15 commits into from Apr 22, 2019

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Apr 19, 2019 •
edited

Update php packages:

  • ast to 1.0.1
  • igbinary to 3.0.1
  • redis to 4.3.0
  • composer to 1.8.5
  • php-cs-fixer to 2.14.2
  • phpcs to 3.4.2
  • phpcbf to 3.4.2
  • psysh to 0.9.9
  • oci8 to 2.2.0

Mark package php_excel broken.
Mark package v8 v8js broken - error build package pkgs.v8_6_x
Sort php packages alphabetically.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 19, 2019

@GrahamcOfBorg build php71Packages-unit.apcu php71Packages-unit.apcu_bc php71Packages-unit.ast php71Packages-unit.box php71Packages-unit.composer php71Packages-unit.couchbase php71Packages-unit.igbinary php71Packages-unit.imagick php71Packages-unit.mailparse php71Packages-unit.memcached php71Packages-unit.pcs php71Packages-unit.pdo_sqlsrv php71Packages-unit.php-cs-fixer php71Packages-unit.php-parallel-lint php71Packages-unit.phpcbf php71Packages-unit.phpcs php71Packages.psysh php71Packages-unit.redis php71Packages-unit.sqlsrv php71Packages-unit.xdebug php71Packages-unit.yaml php71Packages-unit.zmq php71Packages.apcu php71Packages.apcu_bc php71Packages.ast php71Packages.box php71Packages.composer php71Packages.couchbase php71Packages.igbinary php71Packages.imagick php71Packages.mailparse php71Packages.memcached php71Packages.pcs php71Packages.pdo_sqlsrv php71Packages.php-cs-fixer php71Packages.php-parallel-lint php71Packages.phpcbf php71Packages.phpcs php71Packages.redis php71Packages.sqlsrv php71Packages.xdebug php71Packages.yaml php71Packages.zmq php72Packages-unit.apcu php72Packages-unit.apcu_bc php72Packages-unit.ast php72Packages-unit.box php72Packages-unit.composer php72Packages-unit.couchbase php72Packages-unit.igbinary php72Packages-unit.imagick php72Packages-unit.mailparse php72Packages-unit.memcached php72Packages-unit.pcs php72Packages-unit.pdo_sqlsrv php72Packages-unit.php-cs-fixer php72Packages-unit.php-parallel-lint php72Packages-unit.phpcbf php72Packages-unit.phpcs php72Packages-unit.redis php72Packages-unit.sqlsrv php72Packages-unit.xdebug php72Packages-unit.yaml php72Packages-unit.zmq php72Packages.apcu php72Packages.apcu_bc php72Packages.ast php72Packages.box php72Packages.composer php72Packages.couchbase php72Packages.igbinary php72Packages.imagick php72Packages.mailparse php72Packages.memcached php72Packages.pcs php72Packages.pdo_sqlsrv php72Packages.php-cs-fixer php72Packages.php-parallel-lint php72Packages.phpcbf php72Packages.phpcs php72Packages.redis php72Packages.sqlsrv php72Packages.xdebug php72Packages.yaml php72Packages.zmq php73Packages-unit.apcu php73Packages-unit.apcu_bc php73Packages-unit.ast php73Packages-unit.box php73Packages-unit.composer php73Packages-unit.couchbase php73Packages-unit.igbinary php73Packages-unit.imagick php73Packages-unit.memcached php73Packages-unit.pcs php73Packages-unit.pdo_sqlsrv php73Packages-unit.php-cs-fixer php73Packages-unit.php-parallel-lint php73Packages-unit.phpcbf php73Packages-unit.phpcs php73Packages-unit.redis php73Packages-unit.sqlsrv php73Packages-unit.xdebug php73Packages-unit.yaml php73Packages.apcu php73Packages.apcu_bc php73Packages.ast php73Packages.box php73Packages.composer php73Packages.couchbase php73Packages.igbinary php73Packages.imagick php73Packages.memcached php73Packages.pcs php73Packages.pdo_sqlsrv php73Packages.php-cs-fixer php73Packages.php-parallel-lint php73Packages.phpcbf php73Packages.phpcs php73Packages.redis php73Packages.sqlsrv php73Packages.xdebug php73Packages.yaml

@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 19, 2019

@GrahamcOfBorg build php71Packages-unit.oci8 php71Packages-unit.v8 php71Packages-unit.v8js php71Packages.oci8 php71Packages.v8 php71Packages.v8js php72Packages-unit.oci8 php72Packages-unit.v8 php72Packages-unit.v8js php72Packages.oci8 php72Packages.v8 php72Packages.v8js php73Packages-unit.oci8 php73Packages-unit.v8 php73Packages.oci8 php73Packages.v8

@etu
Copy link
Contributor

etu commented Apr 20, 2019

@GrahamcOfBorg build php71Packages-unit.oci8 php71Packages.oci8 phpPackages-unit.oci8 phpPackages.oci8 php73Packages-unit.oci8 php73Packages.oci8

These failed for me when I did a nix-review of this PR. It also skipped the ones marked as broken. The rest did build locally.

@etu
Copy link
Contributor

etu commented Apr 20, 2019

I see, it's because they are unfree and require pre-downloading of the source... Well, that's fine then.

aanderse
aanderse requested changes Apr 20, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if the git history could be cleaned up a bit. For example the first 9 commits are incorrect in that they set pname = "name-${version}"; which I don't think would actually build. Bonus points for any other changes which would make this more readable.

@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 20, 2019

Could not fix it. Need to re-do.

@aanderse
Copy link
Member

aanderse commented Apr 20, 2019 •
edited

oci8 builds for php 7.1 and 7.2, but not 7.3. Unfortunately it appears this is the case in 19.03 as well... so unrelated to this PR. Everything OK with building oci8 on this PR from my perspective.

NOTE: from oci8 2.2.0 changelog:

Fixed installation on PHP 7.3.

I have confirmed this version bump fixes the build: bd44f7a and I will update when I have run proper tests.

@Izorkin please feel free to include the commit I have posted into this PR.
I have created #59926 for the oci8 bump as it will need to be backported as a break fix.

@GrahamcOfBorg GrahamcOfBorg requested a review from etu April 20, 2019 14:48
@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 20, 2019

Updated PR

@aanderse aanderse mentioned this pull request Apr 20, 2019
Closed
10 tasks
@Izorkin Izorkin changed the title Update php packages phpPackages: update php packages Apr 21, 2019
@etu
Copy link
Contributor

etu commented Apr 22, 2019

I think this is possible to merge by now, it also integrated #59926 by @aanderse.

What do you think?

For backporting the oci8 changes we should be able to cherry-pick it. No biggie that it's part of this PR I'd say.

@aanderse
Copy link
Member

@Izorkin thank you for going through and cleaning up the commit history on this! Much easier to follow now.

Final question: some of the packages you renamed to "php-oldname" (for example, composer -> php-composer) but not all. What was the reasoning here?

@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 22, 2019 •
edited

Example:
old variant - /nix/store/mgcfk8pdb9b86cwgfx5ap6wrdvdz5k90-composer-1.8.4
new variant - /nix/store/mgcfk8pdb9b86cwgfx5ap6wrdvdz5k90-php-composer-1.8.4

@infinisil infinisil merged commit eb67898 into NixOS:master Apr 22, 2019
@infinisil
Copy link
Member

oci8 update backported with d8cf9d8

@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 23, 2019

Thanks!

@Izorkin Izorkin deleted the php-packages branch April 23, 2019 04:52
@Izorkin Izorkin mentioned this pull request Apr 23, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@globin globin Awaiting requested review from globin globin is a code owner

@jtojnar jtojnar Awaiting requested review from jtojnar jtojnar is a code owner

@etu etu Awaiting requested review from etu

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Izorkin @etu @aanderse @infinisil @jtojnar @GrahamcOfBorg