-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 9289a39a6987
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cccc7a93d28c
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 5 commits
- 1 file changed
- 1 contributor
Commits on Apr 17, 2019
-
nixos/prometheus: filter out the _module attr in a central place
We previously filtered out the `_module` attribute in a NixOS configuration by filtering it using the option's `apply` function. This meant that every option that had a submodule type needed to have this apply function. Adding this function is easy to forget thus this mechanism is error prone. We now recursively filter out the `_module` attributes at the place we construct the Prometheus configuration file. Since we now do the filtering centrally we don't have to do it per option making it less prone to errors.
Configuration menu - View commit details
-
Copy full SHA for 57e5b75 - Browse repository at this point
Copy the full SHA 57e5b75View commit details -
nixos/prometheus: set optional attributes to type types.nullOr
This makes sure that when a user hasn't set a Prometheus option it won't show up in the prometheus.yml configuration file. This results in smaller and easier to understand configuration files.
Configuration menu - View commit details
-
Copy full SHA for 55ef5d4 - Browse repository at this point
Copy the full SHA 55ef5d4View commit details
Commits on Apr 18, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 285fd3c - Browse repository at this point
Copy the full SHA 285fd3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for cdd8268 - Browse repository at this point
Copy the full SHA cdd8268View commit details -
Merge pull request #59828 from basvandijk/prometheus-refactoring
nixos/prometheus: refactored & added more missing options
Configuration menu - View commit details
-
Copy full SHA for cccc7a9 - Browse repository at this point
Copy the full SHA cccc7a9View commit details
There are no files selected for viewing