Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/systemd: add an option to suppress system units #59827

Merged
merged 1 commit into from Feb 6, 2020
Merged

nixos/systemd: add an option to suppress system units #59827

merged 1 commit into from Feb 6, 2020

Conversation

oxij
Copy link
Member

@oxij oxij commented Apr 18, 2019

What? Why?

Originally #59742, but I also comment-out a bunch of upstream units (e.g. rescue and time-sync things) on my NixOS+systemd systems anyway, so this feature is warranted even without that PR, IMHO.

git log

  • nixos/systemd: add an option to suppress system units

nix-instantiate environment

  • Host OS: Linux 4.9, SLNOS 19.09
  • Nix: nix-env (Nix) 2.2
  • Multi-user: yes
  • Sandbox: yes
  • NIXPKGS_CONFIG:
{
  checkMeta = true;
  doCheckByDefault = true;
}

nix-env -qaP diffs

  • On x86_64-linux:
    • Updated (1):
      • tests.nixos-functions.nixos-test
  • On aarch64-linux: ditto
  • On x86_64-darwin: noop

@oxij oxij requested a review from infinisil as a code owner April 18, 2019 10:54
@oxij oxij mentioned this pull request Apr 18, 2019
Closed
10 tasks
infinisil
infinisil approved these changes Apr 22, 2019
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oxij
Copy link
Member Author

oxij commented Feb 6, 2020

ping?

@infinisil infinisil merged commit 5acd168 into NixOS:master Feb 6, 2020
@oxij
Copy link
Member Author

oxij commented Feb 9, 2020

Thanks!

@oxij oxij deleted the nixos/suppress-systemd-units branch August 12, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oxij @infinisil @GrahamcOfBorg