Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-zsh-completions: 0.4.2 -> 0.4.3 #59821

Merged
merged 1 commit into from Apr 18, 2019
Merged

nix-zsh-completions: 0.4.2 -> 0.4.3 #59821

merged 1 commit into from Apr 18, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Apr 18, 2019 •
edited

Motivation for this change

Added new completions for nixos-build-vms[1].

See https://github.com/spwhitt/nix-zsh-completions/releases/tag/0.4.3

[1] #55121 added support for
--option.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
nix-zsh-completions: 0.4.2 -> 0.4.3
b9cacc1 
Added new completions for `nixos-build-vms`[1].

See https://github.com/spwhitt/nix-zsh-completions/releases/tag/0.4.3

[1] NixOS#55121 added support for
`--option`.
@Ma27 Ma27 requested a review from hedning April 18, 2019 09:38
hedning
hedning approved these changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@hedning hedning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also adds nix-review completion.

@hedning hedning merged commit 99930ca into NixOS:master Apr 18, 2019
@Ma27 Ma27 deleted the bump-nix-zsh-completions branch April 18, 2019 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning hedning approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @hedning @GrahamcOfBorg