build: add exit code for hash and check mismatches #2779
Conversation
src/libstore/build.cc
Outdated
| @@ -4374,7 +4384,7 @@ void Worker::waitForInput() | |||
|
|
|||
| unsigned int Worker::exitStatus() | |||
| { | |||
| return timedOut ? 101 : (permanentFailure ? 100 : 1); | |||
| return checkMismatch ? 103 : (hashMismatch ? 102 : (timedOut ? 101 : (permanentFailure ? 100 : 1))); | |||
There was a problem hiding this comment.
It might be time to make this a proper if chain :)
There was a problem hiding this comment.
Moving the status codes to exception types is also an option, not sure if there's a reason why it's stored in flags separately instead.
There was a problem hiding this comment.
Maybe we should make this an OR of bits (e.g. 4 == check mismatch, 8 == hash mismatch etc.).
There was a problem hiding this comment.
Updated. What's the best place to document this, the nix-store --realise section?
LnL7
force-pushed
the
build-exit-codes
branch
2 times, most recently
from
d6651da
to
3eacb18
Compare
Makes it easier to identify the failure reason in other tooling, eg. differentiate between a non-deterministic --check vs a failed build. $ nix-build '<nix/fetchurl.nix>' --argstr url http://example.org --argstr sha256 0000000000000000000000000000000000000000000000000000 hash mismatch in fixed-output derivation '/nix/store/nzi9ck45rwlxzcwr25is7qlf3hs5xl83-example.org': wanted: sha256:0000000000000000000000000000000000000000000000000000 got: sha256:08y4734bm2zahw75b16bcmcg587vvyvh0n11gwiyir70divwp1rm $ echo $? 102 $ nix-build -E 'with import <nixpkgs> {}; runCommand "foo" {} "date +%s > $out"' --check warning: rewriting hashes in '/nix/store/g3k47g0399fvjmbm0p0mnad74k4w8vkz-foo'; cross fingers error: derivation '/nix/store/mggc8dz13ackb49qca6m23zq4fpq132q-foo.drv' may not be deterministic: output '/nix/store/g3k47g0399fvjmbm0p0mnad74k4w8vkz-foo' differs $ echo $? 104
If multiple builds with fail with different errors it will be reflected in the status code. eg. 103 => timeout + hash mismatch 105 => timeout + check mismatch 106 => hash mismatch + check mismatch 107 => timeout + hash mismatch + check mismatch
| if (buildFailure) | ||
| mask |= 0x04; // 100 | ||
| if (timedOut) | ||
| mask |= 0x01; // 101 |
There was a problem hiding this comment.
This produces a value of 0x61 == 97 right?
There was a problem hiding this comment.
Would be nice to make this tested explicitly.
There was a problem hiding this comment.
0x04 + 0x01 + 0x60 (below) produces 101
Also I added a test ensuring this behavior remains true. Should be good to go?
|
Thanks! |
Makes it easier to identify the failure reason in other tooling, eg.
differentiate between a non-deterministic --check vs a failed build.
/cc @grahamc