Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pythonPackages.moviepy #59862

Merged
merged 4 commits into from Apr 20, 2019
Merged

Fix pythonPackages.moviepy #59862

merged 4 commits into from Apr 20, 2019

Conversation

JohnAZoidberg
Copy link
Member

Motivation for this change

The package was updated in #55757 but the list of dependencies was not.
Now it build again and I can import it in python3.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@JohnAZoidberg JohnAZoidberg mentioned this pull request Apr 19, 2019
Closed
@markuskowa
Copy link
Member

markuskowa commented Apr 19, 2019 •
edited

@GrahamcOfBorg build python37Packages.moviepy
@GrahamcOfBorg build python27Packages.moviepy

@markuskowa
Copy link
Member

Needs backport to 19.03

@markuskowa
Copy link
Member

It looks like python-2.7 is not supported anymore. Can you please mark it broken for python-2.7?

@JohnAZoidberg
Copy link
Member Author

JohnAZoidberg commented Apr 19, 2019 •
edited

It looks like python-2.7 is not supported anymore. Can you please mark it broken for python-2.7?

Thanks! Wasn't aware we had the capability to do that for specific versions :)

@JohnAZoidberg
pythonPackages.moviepy: Add optional deps
64476e8 
Don't include them by default because they increase the derivation size
from ~200M to over 600M.
@markuskowa markuskowa merged commit 276d824 into NixOS:master Apr 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JohnAZoidberg @markuskowa @GrahamcOfBorg