Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildMix: fix bootstrapping packages with hyphens in version #59854

Merged
merged 1 commit into from Apr 20, 2019
Merged

buildMix: fix bootstrapping packages with hyphens in version #59854

merged 1 commit into from Apr 20, 2019

Conversation

goodsoft
Copy link
Contributor

Motivation for this change

I'm using buildMix to build a package, which has a dependency with a hyphen in its version: dialyxir-1.0.0-rc6.
Due to mix-bootstrap using string:tokens the dependency ends up in _build/prod/lib/dyalyxir1.0.0rc6 instead of _build/prod/lib/dialyxir.

Here I'm fixing it to use string:split, which splits by first hyphen only, and returns an array with no more than two elements.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@goodsoft
buildMix: fix bootstrapping packages with hyphens in version
0d9575c 
I'm using `buildMix` to build a package, which has a dependency with a hyphen in its version: `dialyxir-1.0.0-rc6`.
Due to `mix-bootstrap` using `string:tokens` the dependency ends up in `_build/prod/lib/dyalyxir1.0.0rc6` instead of `_build/prod/lib/dialyxir`.
Here I'm fixing it to use `string:split`, which splits by first hyphen only, and returns an array with no more than two elements.
@joachifm joachifm merged commit f0a49c1 into NixOS:master Apr 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: erlang 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@goodsoft @joachifm @GrahamcOfBorg @Janik-Haag