Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpPackages.oci8: 2.1.8 -> 2.2.0 #59926

Closed
wants to merge 1 commit into from
Closed

phpPackages.oci8: 2.1.8 -> 2.2.0 #59926

wants to merge 1 commit into from

Conversation

aanderse
Copy link
Member

Motivation for this change

php73Packages.oci8 is broken on 19.03 as php7.3 is broken in oci8 2.1.8 according to upstream. The 2.2.0 has addressed this problem. This should be backported to 19.03 as well as it is break fix.

Note: This package depends on a non-free package and requires an external download + an account.

Things done

I have successfully built php71Packages.oci8, php72Packages.oci8, php73Packages.oci8, php71Packages-unit.oci8, php72Packages-unit.oci8, and php73Packages-unit.oci8 against this PR, and have tested the new version of oci8 on php 7.1 and 7.2 on 18.09.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

ping @etu & @Ma27

@aanderse aanderse mentioned this pull request Apr 20, 2019
Merged
10 tasks
etu
etu approved these changes Apr 20, 2019
View reviewed changes
Copy link
Contributor

@etu etu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we may want to wait for #59904 to merge and rebase this on top to not cause conflicts.

@aanderse
Copy link
Member Author

But we may want to wait for #59904 to merge and rebase this on top to not cause conflicts.

My motivation for a separate PR was to make this easier to backport. #59904 changes quite a bit and makes a straight cherry pick not possible. I'm good either way though, so long as we backport the update to 19.03 😄

infinisil pushed a commit that referenced this pull request Apr 22, 2019
@Izorkin @infinisil
phpPackages.oci8: 2.1.8 -> 2.2.0
d8cf9d8 
(cherry picked from commit 7fb1b02)

Backported because it oci8 is broken on 19.03, see #59926 as well
@infinisil infinisil closed this Apr 22, 2019
@aanderse aanderse deleted the oci8-bump branch April 22, 2019 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu etu approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aanderse @etu @infinisil @GrahamcOfBorg