ocamlPackages.re: seq is not needed when OCaml >= 4.07 #59876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zimmi48
changed the title
Zimmi48
force-pushed
the
seq
branch
2 times, most recently
from
b4d4148
to
c2612dc
Compare
Zimmi48
changed the title
|
cc @vbgl |
vbgl
requested changes
May 3, 2019
Imitate opam which installs the real seq package only for OCaml < 4.07 and only a META file for OCaml >= 4.07.
|
Like this? |
|
@GrahamcOfBorg build ocaml-ng.ocamlPackages_4_07.seq ocamlPackages.seq |
vbgl
approved these changes
May 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Imitate opam which installs the real seq package only for OCaml < 4.07 and only a META file for OCaml >= 4.07.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)I am not sure how to test the depending packages from the
ocaml-ng.ocamlPackages_4_07package set. The ones from the default set (4.06) are unchanged and thus not rebuilt bynix-review.I have tested a few depending packages though, including odoc.