Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

perlPackages.libapreq2: install the perl & apache modules (19.03 backport) #59910

Merged
merged 1 commit into from Apr 22, 2019

Conversation

aanderse
Copy link
Member

(cherry picked from commit 2f25d58)

Motivation for this change

19.03 backport of #59861 because libapreq2 is missing required functionality and is almost useless as is. This is safe for a backport because it doesn't modify touch any existing functionality, only adds missing (expected) features.

ping @xeji as you seem to be keen on merging perl related PRs 馃槃
NOTE: @volth has given me the "LGTM" on this change.

Things done

See #59861 for details.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member Author

Thanks! 鉂わ笍

@aanderse aanderse deleted the libapreq2-backport branch April 22, 2019 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants