Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prodigal: init at 2.6.3 #59834

Merged
merged 1 commit into from Apr 19, 2019
Merged

Prodigal: init at 2.6.3 #59834

merged 1 commit into from Apr 19, 2019

Conversation

luispedro
Copy link
Contributor

Motivation for this change

Prodigal is widely used in bioinformatics.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • other Linux distributions
  • Tested execution of all binary files (usually in ./result/bin/)

marsam
marsam reviewed Apr 19, 2019
View reviewed changes
Copy link
Contributor

@marsam marsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a pair of comments, otherwise LGTM

pkgs/applications/science/biology/prodigal/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/biology/prodigal/default.nix Outdated Show resolved Hide resolved
@luispedro
Copy link
Contributor Author

Thanks! I implemented the comments.

@marsam
Copy link
Contributor

marsam commented Apr 19, 2019

@GrahamcOfBorg build prodigal

@marsam marsam merged commit f84a7b3 into NixOS:master Apr 19, 2019
@marsam
Copy link
Contributor

marsam commented Apr 19, 2019

Thanks!

@luispedro luispedro deleted the add_prodigal branch April 22, 2019 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@luispedro @marsam @GrahamcOfBorg