Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appleseed: 1.9.0-beta -> 2.0.5-beta (fixes build) #59933

Merged
merged 1 commit into from Apr 24, 2019
Merged

appleseed: 1.9.0-beta -> 2.0.5-beta (fixes build) #59933

merged 1 commit into from Apr 24, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Apr 20, 2019 •
edited

Motivation for this change

appleseed's build looks like it was broken by a bump of osl. 1.9.0-beta doesn't seem to build against this new version, but 2.0.5-beta does, provided we set -Wno-unused-but-set-variable

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

When I run it:

$ result/bin/appleseed.studio
2019-04-22T22:02:58.987150Z <001>    42 MB info    | PYTHONHOME environment variable not set or empty: embedded Python interpreter will use Python installation expected to exist in /nix/store/d31ndn4nwmh1aw8pamizjin1q90v6bn2-appleseed-2.0.5-beta.
ImportError: No module named site

You should probably wrap it with python somehow.

@risicle
Copy link
Contributor Author

risicle commented Apr 23, 2019

Oh dear. Will have to look at that.

@risicle
appleseed: 1.9.0-beta -> 2.0.5-beta
b30f1e9 
this also fixes the build, provided we set -Wno-unused-but-set-variable
@risicle
Copy link
Contributor Author

risicle commented Apr 23, 2019 •
edited

Fixed. Thanks for giving it a check.

@infinisil infinisil merged commit 613fd44 into NixOS:master Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@risicle @infinisil @GrahamcOfBorg