Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HylaFAX: fix ModemGroup, also minor metadata updates (backport to release-19.03) #59894

Merged
merged 3 commits into from Apr 22, 2019
Merged

HylaFAX: fix ModemGroup, also minor metadata updates (backport to release-19.03) #59894

merged 3 commits into from Apr 22, 2019

Conversation

Yarny0
Copy link
Contributor

@Yarny0 Yarny0 commented Apr 19, 2019

Motivation for this change

This is a backport of #59081 .

HylaFAX+ handles the ModemGroup parameter differently from the way the relevant manpage claims it is handled. This can lead to stuck jobs.
I'm using this opportunity to update/improve further minor aspects of the HylaFAX package and module.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS ( note: no change to the package itself, only hylafax configuration in nixos module and package metadata )
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Yarny0
nixos/hylafax: add 'yarny' (= myself) as maintainer
803d10f 
I forgot to do this when I submitted this module with
commit 12fa95f.

(cherry picked from commit 1438f7b)
@Yarny0
nixos/hylafax: fix faxq ModemGroup setting
05459ce 
The manpage claims that the "limit" in the setting::
  <name>:[<limit>:]<regex>
is optional and defaults to zero, implying no limit.
However, tests confirmed that it actually isn't optional.

Without limit, the setting ``any:.*`` places
outbound jobs on infinite hold if no particular
modem was specified on the sendfax command line.
The new default value ``any:0:.*`` from
this commit uses any available modem to
send jobs if not modem was given to sendfax.

(cherry picked from commit e57156b)
@Yarny0
hylafaxplus: update meta
437f5c3 
* move meta attrset into curly brackets
* update homepage (finally supports https)
* add downloadPage
* add longDescription

(cherry picked from commit 729ce1c)
@Yarny0 Yarny0 requested a review from infinisil as a code owner April 19, 2019 15:19
@infinisil infinisil merged commit 2461d60 into NixOS:release-19.03 Apr 22, 2019
@Yarny0 Yarny0 deleted the hylafax-updates-19.03 branch April 24, 2019 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil infinisil is a code owner

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Yarny0 @infinisil @GrahamcOfBorg