Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.tyxml: 4.2.0 -> 4.3.0 and related updates #59892

Merged
merged 2 commits into from Apr 28, 2019
Merged

ocamlPackages.tyxml: 4.2.0 -> 4.3.0 and related updates #59892

merged 2 commits into from Apr 28, 2019

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Apr 19, 2019

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

Why remove ojquery?

@vbgl
Copy link
Contributor Author

vbgl commented Apr 23, 2019 •
edited

ojquery has been removed because it is not compatible with js_of_ocaml ≥ 3.3

Just rebased to fix a conflict.

@vbgl
ocamlPackages.ojquery: remove at 0.1
18fe3e2
@vbgl
ocamlPackages.tyxml: 4.2.0 -> 4.3.0
8b29a8c 
ocamlPackages.eliom: 6.4.0 -> 6.7.0
ocamlPackages.js_of_ocaml: 3.2.1 -> 3.3.0
@vbgl vbgl merged commit 2406c06 into NixOS:master Apr 28, 2019
@vbgl vbgl deleted the ocaml-tyxml-4.3.0 branch April 28, 2019 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 8.has: clean-up 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @infinisil @GrahamcOfBorg