Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-ignore: 0.2.0 -> 1.0.0 #59889

Merged
merged 2 commits into from Apr 20, 2019
Merged

git-ignore: 0.2.0 -> 1.0.0 #59889

merged 2 commits into from Apr 20, 2019

Conversation

sondr3
Copy link
Contributor

@sondr3 sondr3 commented Apr 19, 2019

Motivation for this change

Update my own package to the latest release.

Things done

Tested by installing on my NixOS and macOS machine with nix-env -f . -i git-ignore in the nixpkgs directory.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
git-ignore: split outputs
dd5ac26 
Use a separate `man` output[1]. All outputs will be installed when using
the package i.e. with `nix-env -f . -iA gitAndTools.git-ignore`.

[1] https://nixos.org/nix/manual/#ssec-derivation
@Ma27
Copy link
Member

Ma27 commented Apr 20, 2019

Built and tested locally.

@sondr3 I modified the expression to have split output paths for man pages. If this is fine for you, I'd merge this.

@sondr3
Copy link
Contributor Author

sondr3 commented Apr 20, 2019

I don’t mind, no. Just curious as to why? I took inspiration from the ripgrep derivation and it doesn’t do this, is the split output thing a better way to do it?

@Ma27
Copy link
Member

Ma27 commented Apr 20, 2019

Split outputs may be useful e.g. when referencing a package somewhere else (e.g. in a script) where you don't need man pages. In such a case you have a lower closure size and less to download. A more detailed explanation can be found in the Nix manual.

It's actually a pretty common convention for packages (just grep for $man or outputs = [ "out" "man" for instance).

@Ma27 Ma27 merged commit f1c5590 into NixOS:master Apr 20, 2019
@Ma27
Copy link
Member

Ma27 commented Apr 20, 2019

@sondr3 thanks!

@sondr3 sondr3 deleted the sondr3/git-ignore-1.0.0 branch April 20, 2019 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sondr3 @Ma27 @GrahamcOfBorg