Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-outdated: init at unstable-2019-04-13 #59893

Merged
merged 1 commit into from Apr 24, 2019
Merged

cargo-outdated: init at unstable-2019-04-13 #59893

merged 1 commit into from Apr 24, 2019

Conversation

sondr3
Copy link
Contributor

@sondr3 sondr3 commented Apr 19, 2019 •
edited

Motivation for this change

This is a pretty useful package for seeing what you can/should update with Cargo that currently can't be straight up installed unless you have openssl and pkgconfig available (and working, doesn't work on my machine).

NOTE: I have to install this from the latest commit on master right now as there is an issue with Cargo.lock not being correct, see this PR.

Things done

However, this package depends on #57017 as the generated Cargo.lock cannot be parsed by the old version of cargo-vendor in our repo. I'll update this once/if that is merged. It's been merged and it builds fine.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sondr3 sondr3 force-pushed the sondr3/cargo-outdated-init branch 3 times, most recently from 4495994 to a0c3942 Compare April 22, 2019 15:07
@sondr3
Copy link
Contributor Author

sondr3 commented Apr 22, 2019

I've updated the package and fixed it building, want to take a second look @dywedir? Want to make sure I do it correctly since I'm not building from a tag, see the note in the PR.

@dywedir dywedir marked this pull request as ready for review April 24, 2019 09:48
@dywedir dywedir changed the title [WIP] cargo-outdated: init at 0.8.0 cargo-outdated: init at unstable-2019-04-13 Apr 24, 2019
@dywedir
Copy link
Member

dywedir commented Apr 24, 2019

@GrahamcOfBorg build cargo-outdated

@dywedir
Copy link
Member

dywedir commented Apr 24, 2019

@sondr3 thanks!

@dywedir dywedir merged commit ad4f7dd into NixOS:master Apr 24, 2019
@sondr3 sondr3 deleted the sondr3/cargo-outdated-init branch April 24, 2019 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dywedir dywedir dywedir left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sondr3 @dywedir @GrahamcOfBorg