nixos/deepin: use only one module for deepin services #59943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 21, 2019
Closed
10 tasks
|
Add |
worldofpeace
reviewed
May 2, 2019
|
Added |
The deepin module is used to set basic dbus and systedmd services, kernel modules, groups and users needed by the Deepin Desktop Environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Use a single module for the dbus services, systemd services, kernel modules, groups and users needed by some deepin applications and for the deepin desktop environment.
The services needed for applications that can be run outside of the deepin desktop environment can be enabled independently. The ones that are useful only for running the desktop are kept together.
About packaging deepin for NixOS: #59023
See also #59560 (comment).
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)