Add compatibility with >=pillow-6.0.0 #29
Merged
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe also a note to say minimal Pillow version is now 5.2 ? |
|
As a addition to the not found message? |
|
I mean in the readme :) |
ConiKost
added a commit
to ConiKost/gentoo
that referenced
this pull request
Apr 18, 2019
Patch submitted upstream: OpenTTD/nml#29 Package-Manager: Portage-2.3.63, Repoman-2.3.12 Signed-off-by: Conrad Kostecki <conrad@kostecki.com>
ConiKost
added a commit
to ConiKost/gentoo
that referenced
this pull request
Apr 18, 2019
Patch submitted upstream: OpenTTD/nml#29 Package-Manager: Portage-2.3.63, Repoman-2.3.12 Signed-off-by: Conrad Kostecki <conrad@kostecki.com>
Changed VERSION to PILLOW_VERSION, as it got removed with >=pillow-6.0.0. Signed-off-by: Conrad Kostecki <conrad@kostecki.com>
|
Done. |
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Apr 18, 2019
Patch submitted upstream: OpenTTD/nml#29 Package-Manager: Portage-2.3.63, Repoman-2.3.12 Signed-off-by: Conrad Kostecki <conrad@kostecki.com> Closes: #11734 Signed-off-by: James Le Cuirot <chewi@gentoo.org>
LordAro
approved these changes
Jun 3, 2019
|
Apparently |
|
Ha. Will reopen the original issue |
matthijskooijman
added a commit
to matthijskooijman/nml
that referenced
this pull request
Nov 17, 2019
Previously, this tried various combinations of version variables. However, some of these are deprecated by Pillow and the 6.0.0 release notes recommend simply using `PIL.__version` instead. This attribute is available since Pillow 3.4.0, so there is no need for any compatibility fallbacks. This relates to OpenTTD#29, OpenTTD#39 and OpenTTD#54.
matthijskooijman
added a commit
to matthijskooijman/nml
that referenced
this pull request
Nov 29, 2019
Previously, this tried various combinations of version variables. However, some of these are deprecated by Pillow and the 6.0.0 release notes recommend simply using `PIL.__version` instead. This attribute is available since Pillow 3.4.0, so there is no need for any compatibility fallbacks. This relates to OpenTTD#29, OpenTTD#39 and OpenTTD#54.
LordAro
pushed a commit
that referenced
this pull request
Nov 29, 2019
Previously, this tried various combinations of version variables. However, some of these are deprecated by Pillow and the 6.0.0 release notes recommend simply using `PIL.__version` instead. This attribute is available since Pillow 3.4.0, so there is no need for any compatibility fallbacks. This relates to #29, #39 and #54.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed VERSION to PILLOW_VERSION,
as it got removed with >=pillow-6.0.0.
Signed-off-by: Conrad Kostecki conrad@kostecki.com