Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dosbox: add XDG icon #59956

Merged
merged 1 commit into from Apr 22, 2019
Merged

dosbox: add XDG icon #59956

merged 1 commit into from Apr 22, 2019

Conversation

lightbulbjim
Copy link
Contributor

Motivation for this change

Add an XDG icon for dosbox. The official icon is in .ico format, which
is not compatible with the freedesktop.org spec, so graphicsmagick is
included as a build time dependency and used to convert it to a PNG.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Add an XDG icon for dosbox. The official icon is in .ico format, which
is not compatible with the freedesktop.org spec, so graphicsmagick is
included as a build time dependency and used to convert it to a PNG.
@c0bw3b
Copy link
Contributor

c0bw3b commented Apr 22, 2019

@GrahamcOfBorg build dosbox

@c0bw3b c0bw3b merged commit 8614167 into NixOS:master Apr 22, 2019
@lightbulbjim lightbulbjim deleted the dosbox-icon branch April 26, 2019 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants