Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jool: unstable-20180706 -> 4.0.0 #59920

Merged
merged 2 commits into from Apr 23, 2019
Merged

jool: unstable-20180706 -> 4.0.0 #59920

merged 2 commits into from Apr 23, 2019

Conversation

liclac
Copy link
Contributor

@liclac liclac commented Apr 20, 2019 •
edited

Motivation for this change

Updated jool to version 4.0, and fixed it so that it builds on up-to-date kernels.

Also removed the assertion on the kernel version; upstream doesn't list any constraints on supported kernels anywhere I can see, and if the kernel API makes an incompatible change, we'll notice when it fails to build normally.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@liclac
jool: unstable-20180706 -> 4.0.0
68b4cf3
@liclac
jool: removed kernel version assertion
d88c681 
I don't think this really makes sense, because upstream doesn't list any constraints on supported kernel versions, and worst case it'll just fail to build.
fpletz
fpletz approved these changes Apr 23, 2019
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fpletz fpletz merged commit afe0d73 into NixOS:master Apr 23, 2019
@liclac liclac deleted the update/jool-v4.0.0 branch April 23, 2019 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@liclac @fpletz @GrahamcOfBorg