Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "Prometheus pushgateway 0.4.0 -> 0.8.0 & module" to release 19.03 #59832

Merged
merged 3 commits into from Apr 18, 2019
Merged

Backport "Prometheus pushgateway 0.4.0 -> 0.8.0 & module" to release 19.03 #59832

merged 3 commits into from Apr 18, 2019

Conversation

basvandijk
Copy link
Member

Motivation for this change

I would like to use the latest prometheus pushgateway on NixOS. So this backports the following PRs to release-19.03:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

ivan and others added 3 commits April 18, 2019 14:12
@ivan @basvandijk
prometheus-pushgateway: 0.4.0 -> 0.7.0
ae14052 
Add some tests to make sure the --version output includes the values
passed in with -X.

Add myself as a maintainer.

(cherry picked from commit 8b4b12e)
@basvandijk
prometheus-pushgateway: 0.7.0 -> 0.8.0
a3178b0 
(cherry picked from commit b0fbe1d)
@basvandijk
nixos/prometheus/pushgateway: add module and test
5776161 
(cherry picked from commit d1940be)
@basvandijk
Copy link
Member Author

The following contains a test for the prometheus-pushgateway:

@GrahamcOfBorg test prometheus2

@basvandijk
Copy link
Member Author

@GrahamcOfBorg build prometheus-pushgateway

@basvandijk basvandijk merged commit 31b53e0 into NixOS:release-19.03 Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil infinisil is a code owner

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@basvandijk @GrahamcOfBorg @ivan