Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

steamrt 1.1 -> 1.2 #59838

Merged
merged 1 commit into from Apr 19, 2019
Merged

steamrt 1.1 -> 1.2 #59838

merged 1 commit into from Apr 19, 2019

Conversation

jethrokuan
Copy link
Contributor

@jethrokuan jethrokuan commented Apr 18, 2019 •
edited

Motivation for this change

Update the steam runtime from 1.1 to 1.2.

Initially, ran into the issue described in #59326, but could no longer fetch some of the runtime files because they no longer existed on the mirrors. Updating the runtime with the provided python file fixed things for me.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Slabity Slabity mentioned this pull request Apr 18, 2019
Closed
@chreekat chreekat mentioned this pull request Apr 19, 2019
Closed
@jpotier jpotier mentioned this pull request Apr 19, 2019
Closed
jpotier
jpotier approved these changes Apr 19, 2019
View reviewed changes
Copy link
Contributor

@jpotier jpotier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used this patch, fixes steam launches, all libs found. Working as advertized.

@cpages
Copy link
Contributor

cpages commented Apr 19, 2019

@jpotier steam runs for you because you also had #59326 applied, right? Works for me as well, so I'll merge and backport to stable. Thanks!

@jpotier
Copy link
Contributor

jpotier commented Apr 19, 2019

@cpages yes, I also had 098cf3b348a steam: fix steamrt trying to use a missing setup.sh (#59326) applied.

@cpages cpages merged commit bd32319 into NixOS:master Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpotier jpotier jpotier approved these changes

Assignees
No one assigned
Labels
6.topic: steam 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jethrokuan @cpages @jpotier @GrahamcOfBorg