Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

siji: Also package bdf font #59859

Merged
merged 1 commit into from Apr 20, 2019
Merged

siji: Also package bdf font #59859

merged 1 commit into from Apr 20, 2019

Conversation

JohnAZoidberg
Copy link
Member

@JohnAZoidberg JohnAZoidberg commented Apr 19, 2019 •
edited

Motivation for this change

The pcf version seems to be incompatible with newer FreeType versions
and hence doesn't show up in fc-list. A bdf file format is also
available. After packaging that the font shows up in fc-list.

See: stark/siji#28

Fixes #59847

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@JohnAZoidberg
siji: Also package bdf font
1e05181 
The pcf version seems to be incompatible with newer FreeType versions
and hence doesn't show up in `fc-list`. A bdf file format is also
available. After packaging that the font shows up in `fc-list`.

See: stark/siji#28

Fixes NixOS#59847
@JohnAZoidberg JohnAZoidberg mentioned this pull request Apr 19, 2019
Closed
@marsam
Copy link
Contributor

marsam commented Apr 20, 2019

@GrahamcOfBorg build siji

@marsam marsam merged commit a7e3c84 into NixOS:master Apr 20, 2019
@marsam
Copy link
Contributor

marsam commented Apr 20, 2019

Thanks for looking into this!

@JohnAZoidberg JohnAZoidberg deleted the siji-bdf branch April 20, 2019 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

siji font is installed but not available
3 participants
@JohnAZoidberg @marsam @GrahamcOfBorg