Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pyramid_chameleon: fix build by patching tests #59860

Merged
merged 1 commit into from Apr 19, 2019
Merged

pythonPackages.pyramid_chameleon: fix build by patching tests #59860

merged 1 commit into from Apr 19, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Apr 19, 2019 •
edited

Motivation for this change

Seems to have been broken for a while.

Test suite was failing on a seemingly nonsensical test. Looking into this part of the test suite it appears it started as a modified copy of part of the main pyramid test suite. Presumably this line simply never got converted - change it to match the similar imports.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle risicle requested a review from FRidh as a code owner April 19, 2019 01:12
@risicle
pythonPackages.pyramid_chameleon: fix build by patching tests
504e128 
looking into this part of the test suite it appears it started as a
modified copy of part of the main pyramid test suite. presumably this
line simply never got converted - change it to match the similar
imports.
@domenkozar domenkozar merged commit dbb5e61 into NixOS:master Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@risicle @domenkozar @GrahamcOfBorg