Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.libapreq2: install the perl & apache modules #59861

Merged
merged 1 commit into from Apr 20, 2019
Merged

perlPackages.libapreq2: install the perl & apache modules #59861

merged 1 commit into from Apr 20, 2019

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Apr 19, 2019 •
edited

Motivation for this change

#59773 (comment)

libapreq2 is made up of a c library, a perl module, and an apache module. In nixpkgs libapreq2 does not include the perl or apache modules.

This change adds a perl module and an apache module, while leaving the existing c library completely untouched so is fine to backport to 19.03 as well.

Things done

I have tested the perl and apache modules included in this new libapreq2 build with some existing code which has been running on Debian servers for years now.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member Author

@GrahamcOfBorg build perldevelPackages.libapreq2 perl528Packages.libapreq2

@aanderse aanderse merged commit ca40b73 into NixOS:master Apr 20, 2019
@aanderse aanderse deleted the libapreq2 branch April 20, 2019 00:40
@aanderse aanderse mentioned this pull request Apr 20, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aanderse @GrahamcOfBorg