Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

steamrt: fix update script #59899

Merged
merged 1 commit into from Apr 21, 2019
Merged

steamrt: fix update script #59899

merged 1 commit into from Apr 21, 2019

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Apr 19, 2019 •
edited

Motivation for this change

The package.txt file doesn't exist anymore on upstream.
The new method is to install two metapackages and their dependencies.

Reference : ValveSoftware/steam-runtime@8849d36

Also I reuse the hash given in the package list so it doesn't have to download everything, resulting in way faster speed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nyanloutre
steamrt: fix update script
87e35a1 
The package.txt file doesn't exist anymore on upstream.
The new method is to install two metapackages and their dependencies.

Reference : ValveSoftware/steam-runtime@8849d36
@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/steam-installation-is-failing/2726/3

@c00w
Copy link
Contributor

c00w commented Apr 21, 2019

Looks good to me - excited to see this fixed :D

  • Steam works with the new dependencies.
  • This makes the steam update script work again
  • Commit is well formed.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/22

@markuskowa markuskowa merged commit 034d673 into NixOS:master Apr 21, 2019
@nyanloutre nyanloutre deleted the steam-update-runtime branch April 22, 2019 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: steam 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nyanloutre @nixos-discourse @c00w @GrahamcOfBorg @markuskowa