Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @dingxiangfei2009 to maintainers #59873

Closed
wants to merge 1 commit into from
Closed

Add @dingxiangfei2009 to maintainers #59873

wants to merge 1 commit into from

Conversation

edude03
Copy link
Contributor

@edude03 edude03 commented Apr 19, 2019

Motivation for this change

Move forward the Concourse PR by committing it in smaller chunks. #53691

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tomberek
Copy link
Contributor

Can we merge these two commits together?

@infinisil
Copy link
Member

Also I'd like confirmation by @dingxiangfei2009 that the info is correct. Usually people add themselves.

@edude03
Copy link
Contributor Author

edude03 commented Apr 23, 2019

Yes, it's a bit unorthodox, but I'm helping @dingxiangfei2009 break up #53691 so that we can get it merged faster. My intention is that when he returns and has time to look at it again all of the feedback from the PR will have been addressed.

@dingxiangfei2009
Copy link
Contributor

@infinisil Yes, the information in this PR is correct.

@edude03 is breaking up #53691 into smaller PRs.

@vcunat
Copy link
Member

vcunat commented Apr 23, 2019

Pushed as 3528f88 with fixed ordering.

@vcunat vcunat closed this Apr 23, 2019
vcunat pushed a commit that referenced this pull request Apr 23, 2019
@edude03 @vcunat
Add @dingxiangfei2009 to maintainers list
3528f88 
Reordered version of #59873
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@edude03 @tomberek @infinisil @dingxiangfei2009 @vcunat @GrahamcOfBorg