Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins: update #59874

Merged
merged 1 commit into from Apr 19, 2019
Merged

vimPlugins: update #59874

merged 1 commit into from Apr 19, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented Apr 19, 2019 •
edited

Motivation for this change

Regular update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto
Copy link
Member

teto commented Apr 19, 2019

Care to bump LanguageClient-neovim or should I prepare another PR ? That release can use neovim floating windows which is neat teto@95e4032

@timokau
Copy link
Member Author

timokau commented Apr 19, 2019

Sounds neat! Since that shouldn't generate merge conflicts, eval is nearly done here and its a bit annoying to cherry-pick from a different fork I'd say its easiest you create another PR. Ping me and we should get it merged in no time.

As an aside: How do you notice theses PRs so quickly? This is the second time you've reacted within a couple of minutes.

@teto
Copy link
Member

teto commented Apr 19, 2019

I work for the government :p it could have been the IRC bot but it was just a coincidence, was looking for something else.
When I propose a vimPlugins PR, I'll ping you no worry :D

@timokau timokau merged commit 5e7e5a2 into NixOS:master Apr 19, 2019
@timokau timokau deleted the vim-plugin-update branch April 19, 2019 08:42
@timokau
Copy link
Member Author

timokau commented Apr 19, 2019

I work for the government

That explains it of course :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: vim 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timokau @teto @GrahamcOfBorg