Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wf-recorder: unstable-2019-03-12 -> unstable-2019-04-21 #59960

Merged
merged 1 commit into from Apr 21, 2019
Merged

wf-recorder: unstable-2019-03-12 -> unstable-2019-04-21 #59960

merged 1 commit into from Apr 21, 2019

Conversation

CrazedProgrammer
Copy link
Contributor

Motivation for this change

Updates the wf-recorder program to the latest commit from master. A couple things have been added, most notably audio recording support (hence the new libpulseaudio dependency).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dywedir
Copy link
Member

dywedir commented Apr 21, 2019

@GrahamcOfBorg build wf-recorder

@dywedir dywedir merged commit 1570951 into NixOS:master Apr 21, 2019
@CrazedProgrammer CrazedProgrammer deleted the update-wf-recorder branch April 21, 2019 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CrazedProgrammer @dywedir @GrahamcOfBorg