Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oraclejdk: use working mirror for download #59947

Merged
merged 1 commit into from Apr 25, 2019
Merged

oraclejdk: use working mirror for download #59947

merged 1 commit into from Apr 25, 2019

Conversation

strager
Copy link
Contributor

@strager strager commented Apr 21, 2019

Motivation for this change

http://download.oracle.com/otn-pub/ was recently renamed to http://download.oracle.com/otn/ and now requires authentication with an Oracle account. http://download.oracle.com/otn-pub/ links don't work anymore, so installing oraclejdk fails.

Switch to http://javadl.oracle.com/webapps/download/GetFile/, which does not require authentication. This fixes installing oraclejdk.

Note: The URL for JCE is still broken; this commit only fixes the URL for the JDK.

This commit fixes nixpkgs issue #59761.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@strager
oraclejdk: use working mirror for download
b41983a 
http://download.oracle.com/otn-pub/ was recently renamed to
http://download.oracle.com/otn/ and now requires authentication with an
Oracle account. http://download.oracle.com/otn-pub/ links don't work
anymore, so installing oraclejdk fails.

Switch to http://javadl.oracle.com/webapps/download/GetFile/, which does
not require authentication. This fixes installing oraclejdk.

Note: The URL for JCE is still broken; this commit only fixes the URL
for the JDK.
cawilliamson
cawilliamson approved these changes Apr 21, 2019
View reviewed changes
Copy link
Member

@cawilliamson cawilliamson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just faced this issue and this change does resolve it.

@c0bw3b
Copy link
Contributor

c0bw3b commented Apr 22, 2019

JCE should still be available at the current URL:
https://www.oracle.com/technetwork/java/javase/downloads/jce-all-download-5170447.html

@aanderse
Copy link
Member

I confirmed all 4 platforms nixpkgs supports are valid links, though I'm unsure why they all have linux-i586 in the path... 🤷‍♂️

@FRidh FRidh merged commit 1a00980 into NixOS:master Apr 25, 2019
@FRidh
Copy link
Member

FRidh commented Apr 25, 2019

Seems like the link is actually broken again already.

@aanderse
Copy link
Member

I wouldn't be too surprised if they locked the download down to accounts only 😞
If that ends up being the case ping me and I can test.

@livnev livnev mentioned this pull request Apr 27, 2019
Merged
10 tasks
@jbboehr jbboehr mentioned this pull request May 14, 2019
Closed
@PsyanticY PsyanticY mentioned this pull request Aug 22, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cawilliamson cawilliamson cawilliamson approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@strager @c0bw3b @aanderse @FRidh @cawilliamson @GrahamcOfBorg