Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freecad: 0.17 -> 0.18.1 #59923

Merged
merged 1 commit into from Apr 26, 2019
Merged

freecad: 0.17 -> 0.18.1 #59923

merged 1 commit into from Apr 26, 2019

Conversation

lightbulbjim
Copy link
Contributor

Motivation for this change

Updating to the latest version. Some simplification has been possible as FreeCAD now includes XDG config files in its release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tomberek
Copy link
Contributor

This fails to open a new or existing cad file on non-NixOS (Ubuntu) with this error:

FreeCAD: gl.cpp:2389: const cc_glglue* cc_glglue_instance(int): Assertion `gi->versionstr && "could not call glGetString() -- no current GL context?"' failed.
/home/dev/.nix-profile/bin/nixGLNvidia: line 3:  8594 Aborted                 (core dumped) "$@"

Tried: nixGL and LD_LIBRARY_PATH settings.

@lightbulbjim
Copy link
Contributor Author

This fails to open a new or existing cad file on non-NixOS (Ubuntu) with this error:

Hmm. I don't have an Ubuntu system to test on, but it does look like the error might have something to do with your video card (I'm guessing Nvidia?). FWIW I'm not seeing the error on my NixOS system with Intel HD 520 graphics.

@lightbulbjim
Copy link
Contributor Author

@tomberek do you have another system to test this on? Alternatively, can you try doing a normal source build (outside of Nix) on the failing system?

Not sure how else to move this forward...

@lightbulbjim
freecad: 0.17 -> 0.18.1
2d82f2e 
Notes:
  - boost_python patch has been removed as it's part of the new release.
  - XDG config files have been added as of 0.18 so it's no longer to
  generate the MIME and .desktop files manually.
@gebner
Copy link
Member

gebner commented Apr 26, 2019

I can't reproduce the GL error either (on NixOS). @tomberek Did you update nixGL? Does this error also happen with an ubuntu build of FreeCAD? This might just be an issue with the nvidia driver, if so this should be reported upstream.

@gebner gebner merged commit 2f383a4 into NixOS:master Apr 26, 2019
@lightbulbjim lightbulbjim deleted the freecad-update branch April 26, 2019 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viric viric Awaiting requested review from viric

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lightbulbjim @tomberek @gebner @GrahamcOfBorg