Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modd: init at 0.8 #59898

Merged
merged 1 commit into from Apr 22, 2019
Merged

modd: init at 0.8 #59898

merged 1 commit into from Apr 22, 2019

Conversation

kierdavis
Copy link
Contributor

Motivation for this change

Neat tool that watches files in a project directory and re-runs linters/tests or restarts daemons when a file is modified. More info at project homepage.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

Now just need to rebase such that no merge commits are in there

@kierdavis
Copy link
Contributor Author

@infinisil done

@infinisil infinisil merged commit 076be09 into NixOS:master Apr 22, 2019
@kierdavis
Copy link
Contributor Author

Thanks 👍

@kierdavis kierdavis deleted the init-modd branch April 22, 2019 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kierdavis @infinisil @GrahamcOfBorg