Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rxvt_unicode: allow to specify dependencies for plugins #59896

Merged
merged 2 commits into from Apr 20, 2019
Merged

rxvt_unicode: allow to specify dependencies for plugins #59896

merged 2 commits into from Apr 20, 2019

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Apr 19, 2019 •
edited

Motivation for this change

I needed to add some perl modules for a urxvt script.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change
  • Tested execu (usually in ./result/bin/)tion of all binary files
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@joachifm joachifm merged commit 9241145 into NixOS:master Apr 20, 2019
@joachifm
Copy link
Contributor

LGTM. Thank you

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Apr 20, 2019

Thank you for the review.

@arcnmx arcnmx mentioned this pull request Apr 24, 2019
Merged
10 tasks
@rnhmjoj rnhmjoj deleted the rxvt branch September 14, 2019 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm joachifm left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rnhmjoj @joachifm @GrahamcOfBorg