Miscellaneous cross compilation fixes #59897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spidermonkey doesn’t use the autotools build, host, target convention. Instead it considers ‘--host’ to be the autotools’ ‘--build’ and ‘--target’ to be the autotools’ ‘--host’! As a result, we cannot safely use “configurePlatforms”. Instead, we must manually set these flags. /cc @illegalprime
This avoids part of the issue where things like armv7a don’t work because the system doesn’t realize it can use the armv7l bootstrap tools.
Squashed to fix shell quoting, thanks @Ericson2314
ppc64le and ppc64 are different targets in the configure script. We can’t use the same one. TODO: canonicalize similar ones based on qemu’s configure script.
This makes us less reliant on the systems/examples.nix. You should be
able to cross compile with just your triple:
$ nix build --arg crossSystem '{ config = "armv6l-unknown-linux-gnueabi"; }' stdenv
|
@GrahamcOfBorg eval |
|
@matthewbauer thanks for the spidermonkey fix! |
it’s almost always a better idea to use getBin instead of .bin. Otherwise, we could get an evaluation error if utillinux is missing the bin otuput.
GrahamcOfBorg
added
8.has: package (new)
10.rebuild-darwin: 101-500
and removed
10.rebuild-darwin: 11-100
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a collection of fixes to the cross compilation infrastructures that I have collected. Mostly just stuff that I don't want to forget to merge. Summary:
I can split these up into separate PRs if requested.
/cc @illegalprime
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)