Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nmap: update clang specific patch #67374

Merged
merged 1 commit into from Aug 24, 2019
Merged

nmap: update clang specific patch #67374

merged 1 commit into from Aug 24, 2019

Conversation

thefloweringash
Copy link
Member

@thefloweringash thefloweringash commented Aug 24, 2019 •
edited

The upstream PR had two parts: adding a missing include and resolving
an ambiguous reference. The upstream project fixed the first but not
the second. We still need the second part, so extract it by filtering
the patch.

Motivation for this change

Fixes #67223

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @thoughtpolice @fpletz

@thefloweringash
nmap: update clang specific patch
de1e3c9 
The upstream PR had two parts: adding a missing include and resolving
an ambiguous reference. The upstream project fixed the first but not
the second. We still need the second part, so extract it by filtering
the patch.
@ofborg ofborg bot requested review from thoughtpolice and fpletz August 24, 2019 05:19
@mmahut
Copy link
Member

mmahut commented Aug 24, 2019

@GrahamcOfBorg build nmap

@mmahut mmahut merged commit 5f33345 into NixOS:master Aug 24, 2019
@thefloweringash thefloweringash deleted the nmap-darwin-patch-update branch August 26, 2019 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nmap fails to build on Darwin
2 participants
@thefloweringash @mmahut