Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/gnupg: Add gpg to systemPackages #67409

Merged
merged 1 commit into from Aug 24, 2019
Merged

nixos/gnupg: Add gpg to systemPackages #67409

merged 1 commit into from Aug 24, 2019

Conversation

duhirsch
Copy link

Motivation for this change

When the gpgAgent is enabled, the gpg package is installed in the store but not as systemPackage.
This commit also installs it as systemPackage which is reasonable because the agent is also enabled in the system.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @peti @fpletz @infinisil

@mmahut
Copy link
Member

mmahut commented Aug 24, 2019

This makes sense, thank you.

@mmahut mmahut merged commit 8a41fcb into NixOS:master Aug 24, 2019
@duhirsch duhirsch deleted the module/gpg/addToSystemPackages branch August 24, 2019 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants