Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/ofono: various improvements #67358

Merged
merged 5 commits into from
Aug 24, 2019
Merged

nixos/ofono: various improvements #67358

merged 5 commits into from
Aug 24, 2019
+285 −6

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Aug 23, 2019 •
edited
Loading

Continuation of #66565

Added support for ofono plug-ins:

{ pkgs, ... }: {
  services.ofono.enable = true;
  services.ofono.plugins = [ pkgs.modem-manager-gui ];
}

@jtojnar jtojnar requested a review from infinisil as a code owner August 23, 2019 16:55
@jtojnar jtojnar requested a review from worldofpeace August 23, 2019 16:56
@jtojnar
Copy link
Member Author

jtojnar commented Aug 23, 2019

Trying to make Ofono/ModemManager to work with my Android phone to test calls but so far without success.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Aug 23, 2019
@jtojnar jtojnar force-pushed the ofono-progress branch 3 times, most recently from cf2ce23 to 73640de Compare August 23, 2019 17:12
@ofborg ofborg bot requested a review from alesya-h August 23, 2019 17:27
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Aug 23, 2019
jtojnar added 4 commits August 23, 2019 19:50
@jtojnar
nixos/ofono: add module

Verified

This commit was signed with the committer’s verified signature. The key has expired.
dtzWill Will Dietz
GPG key ID: EBB0EA4124809D02
Expired
Verified
Learn about vigilant mode
f66613b
@jtojnar
modem-manager-gui: add plug-in for ofono
0ae487e
@jtojnar
modem-manager-gui: clean up
1502851
@jtojnar
nixos/ofono: allow adding 3rd party plug-ins
5db7621
@worldofpeace
Copy link
Contributor

worldofpeace commented Aug 23, 2019 •
edited
Loading

#67358 (comment)

Though 300c9a6 does make all packages that use the pkgconfig variable install into /etc. Do we want that?

@jtojnar
Copy link
Member Author

jtojnar commented Aug 23, 2019

I added ofono-phonesim but did not figure out how to use it.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Aug 23, 2019
@jtojnar
Copy link
Member Author

jtojnar commented Aug 23, 2019

Cannot make modem-manager-gui see my mobile phone either. Not sure if Android is supported by ModemManager.

@worldofpeace
Copy link
Contributor

Cannot make modem-manager-gui see my mobile phone either. Not sure if Android is supported by ModemManager.

I don't think it is.

worldofpeace
worldofpeace approved these changes Aug 24, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything LGTM, I'm assuming the patch in ofono will be maintained downstream.

Currently can't test the integration.

@jtojnar jtojnar merged commit edcecfe into NixOS:master Aug 24, 2019
@jtojnar jtojnar deleted the ofono-progress branch August 24, 2019 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace

@infinisil infinisil

@alesya-h alesya-h

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtojnar @worldofpeace