Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdrangel : init at 4.11.7 #67357

Merged
merged 1 commit into from Aug 25, 2019
Merged

sdrangel : init at 4.11.7 #67357

merged 1 commit into from Aug 25, 2019

Conversation

alkeryn
Copy link
Contributor

@alkeryn alkeryn commented Aug 23, 2019 •
edited

Motivation for this change

Sdrangel was missing from nixpkgs

Things done

Added sdrangel derivation and myself to the maintainers list

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

@markuskowa

This is my first PR / nixpkgs contribution so that list is a little overwhelming ^

@alkeryn alkeryn mentioned this pull request Aug 23, 2019
Closed
@alkeryn alkeryn force-pushed the master branch 2 times, most recently from de6cead to 8c3635c Compare August 23, 2019 17:01
markuskowa
markuskowa requested changes Aug 23, 2019
View reviewed changes
Copy link
Member

@markuskowa markuskowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my first PR / nixpkgs contribution so that list is a little overwhelming ^

We'll get through it step by step

pkgs/applications/radio/sdrangel/default.nix Outdated Show resolved Hide resolved
pkgs/applications/radio/sdrangel/default.nix Outdated Show resolved Hide resolved
pkgs/applications/radio/sdrangel/default.nix Outdated Show resolved Hide resolved
pkgs/applications/radio/sdrangel/default.nix Outdated Show resolved Hide resolved
pkgs/applications/radio/sdrangel/default.nix Outdated Show resolved Hide resolved
pkgs/applications/radio/sdrangel/default.nix Outdated Show resolved Hide resolved
pkgs/applications/radio/sdrangel/default.nix Outdated Show resolved Hide resolved
@alkeryn alkeryn force-pushed the master branch 5 times, most recently from f5446ae to ce4a05c Compare August 24, 2019 18:07
@alkeryn alkeryn changed the title sdrangel : init and maintainers: add alkeryn sdrangel : init at 4.11.6 Aug 24, 2019
@alkeryn alkeryn force-pushed the master branch 6 times, most recently from a50c3c1 to a5a8634 Compare August 24, 2019 21:40
@alkeryn
Copy link
Contributor Author

alkeryn commented Aug 24, 2019 •
edited

Made the latest change and it now uses the nixpkgs serialdv and cm256cc
So it should be fine for merging now (note that it might need to be modified to add hardware support (such as hackrf or rtl-sdr later on )) :)

@markuskowa
Copy link
Member

markuskowa commented Aug 24, 2019 •
edited

@GrahamcOfBorg build sdrangel

@alkeryn
Copy link
Contributor Author

alkeryn commented Aug 24, 2019

Oh just changed the rev to a number rather than hash
and also updated it to lattest version ^

@alkeryn alkeryn changed the title sdrangel : init at 4.11.6 sdrangel : init at 4.11.7 Aug 24, 2019
markuskowa
markuskowa requested changes Aug 25, 2019
View reviewed changes
Copy link
Member

@markuskowa markuskowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor cleanups. Looks pretty good now. This may be the last round.

pkgs/applications/radio/sdrangel/default.nix Show resolved Hide resolved
pkgs/applications/radio/sdrangel/default.nix Show resolved Hide resolved
pkgs/applications/radio/sdrangel/default.nix Outdated Show resolved Hide resolved
pkgs/applications/radio/sdrangel/default.nix Outdated Show resolved Hide resolved
@alkeryn alkeryn force-pushed the master branch 2 times, most recently from 3d2fcb2 to 921015c Compare August 25, 2019 11:20
markuskowa
markuskowa approved these changes Aug 25, 2019
View reviewed changes
Copy link
Member

@markuskowa markuskowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats to the completion of your first pull request and thanks for packaging this nice program.

@markuskowa markuskowa merged commit b27b627 into NixOS:master Aug 25, 2019
@alkeryn
Copy link
Contributor Author

alkeryn commented Aug 25, 2019 •
edited

Wew nice; thanks for everything :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar left review comments

@markuskowa markuskowa markuskowa approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alkeryn @markuskowa @doronbehar @Janik-Haag