Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: easyjson, quicktemplate, statik, qtchan, vlang #67236

Merged
merged 5 commits into from Aug 23, 2019
Merged

Update: easyjson, quicktemplate, statik, qtchan, vlang #67236

merged 5 commits into from Aug 23, 2019

Conversation

Chiiruno
Copy link
Contributor

@Chiiruno Chiiruno commented Aug 22, 2019 •
edited

Motivation for this change

General updates for my packages.
meguca/hydron will come later, pending a possible go2nix issue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@srhb
Copy link
Contributor

srhb commented Aug 22, 2019

@GrahamcOfBorg build easyjson quicktemplate statik qtchan vlang

jonringer
jonringer reviewed Aug 22, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pname (I believe) is preferred over name, also, "unstable" shouldn't be part of the package name.

pkgs/applications/networking/browsers/qtchan/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/easyjson/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/easyjson/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/quicktemplate/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/quicktemplate/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/statik/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/statik/default.nix Outdated Show resolved Hide resolved
@worldofpeace
Copy link
Contributor

I'm seeing a lot of these have deps.nix. None of them needed to be updated?

worldofpeace
worldofpeace suggested changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qtchan is packaged improperly for a qt application, and needs updates for wrapQtAppsHook.

See the updated manual

Migration looks like

Note that using qt5's mkDerivation automatically includes wrapQtAppsHook.

@Chiiruno
Copy link
Contributor Author

I'm seeing a lot of these have deps.nix. None of them needed to be updated?

go2nix already checks if there are updates needed for deps.nix, there were none needed in this case.

@Chiiruno
Copy link
Contributor Author

That should take care of the issues.

worldofpeace
worldofpeace approved these changes Aug 23, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, executed all binaries. Checked qtchan is wrapped.

@worldofpeace worldofpeace merged commit a4083fb into NixOS:master Aug 23, 2019
@Chiiruno Chiiruno deleted the dev/general branch August 23, 2019 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Chiiruno @srhb @worldofpeace @jonringer @Madouura