Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osslsigncode: init at unstable-2019-07-25 #67237

Merged
merged 1 commit into from Aug 22, 2019
Merged

osslsigncode: init at unstable-2019-07-25 #67237

merged 1 commit into from Aug 22, 2019

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Aug 22, 2019 •
edited

Motivation for this change

init at unstable-2019-07-25

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Aug 22, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be simplified greatly by using the autoreconfHook.

pkgs/development/tools/osslsigncode/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/osslsigncode/default.nix Outdated Show resolved Hide resolved
jonringer
jonringer approved these changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
binary seems to work
leaf package :)

[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/67237
1 package were build:
osslsigncode

$ nix path-info -Sh ./results/osslsigncode
/nix/store/6gv714drl11ix7fdg8bp7422k7yfxf1k-osslsigncode-unstable-2019-07-25      72.6M

@mmahut mmahut merged commit 085fe1a into NixOS:master Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmahut @jonringer