Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.robotframework-databaselibrary: init at 1.2.4 #67339

Merged

Conversation

talkara
Copy link
Contributor

@talkara talkara commented Aug 23, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
propagatedBuildInputs = [ robotframework ];

meta = with stdenv.lib; {
description = "Database Library contains utilities meant for Robot Framework";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind adding yourself as a maintainer?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I'm hesitant to add packages that no one wants to maintain. But if you're willing to be a maintainer for this, I approve.

@mmahut
Copy link
Member

mmahut commented Aug 23, 2019

@GrahamcOfBorg build python3Packages.robotframework-databaselibrary python2Packages.robotframework-databaselibrary

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
…talkara
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Aug 26, 2019
@mmahut
Copy link
Member

mmahut commented Aug 26, 2019

@GrahamcOfBorg build python3Packages.robotframework-databaselibrary python2Packages.robotframework-databaselibrary

@FRidh FRidh merged commit e7d80e3 into NixOS:master Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants