Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

riot-{web,desktop}: 1.3.0 -> 1.3.3 #67293

Merged
merged 2 commits into from Aug 22, 2019
Merged

riot-{web,desktop}: 1.3.0 -> 1.3.3 #67293

merged 2 commits into from Aug 22, 2019

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Aug 22, 2019

Motivation for this change

Supersedes #67129.
"Desktop" app tested and confirmed to work.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @worldofpeace @bachp

worldofpeace
worldofpeace approved these changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me 👍

Electron update noted.

@worldofpeace worldofpeace merged commit 23dfcf4 into NixOS:master Aug 22, 2019
@pacien
Copy link
Contributor Author

pacien commented Aug 22, 2019

You might consider closing #67129 :)

@worldofpeace
Copy link
Contributor

Thanks, did that @pacien .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pacien @worldofpeace